feat: use CssExtractRspackPlugin to extract CSS #1577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
!canary |
|
!bench |
|
📝 Benchmark detail: Open case: rsbuild-react
case: rsbuild-arco-pro
Threshold exceeded in rsbuild-arco-pro: ["devColdBootTime","buildColdBootTime"] |
|
!bench |
|
📝 Benchmark detail: Open case: rsbuild-react
case: rsbuild-arco-pro
|
|
!bench |
|
📝 Benchmark detail: Open case: rsbuild-react
case: rsbuild-arco-pro
Threshold exceeded in rsbuild-arco-pro: ["devColdBootTime"] |
|
!bench |
|
📝 Benchmark detail: Open case: rsbuild-react
Threshold exceeded in rsbuild-react: ["dependenciesCount"] case: rsbuild-arco-pro
|
chenjiahan
reviewed
May 12, 2024
There was a problem hiding this comment.
can we use a smaller asset, and all assets should be placed at e2e/assets (to be reused)
chenjiahan
reviewed
May 12, 2024
| tools: { | ||
| cssLoader: { | ||
| modules: { | ||
| // TODO: css-loader need support named export when namedExports: false. |
There was a problem hiding this comment.
what do we need to do to support this
chenjiahan
reviewed
May 12, 2024
chenjiahan
reviewed
May 12, 2024
Co-authored-by: neverland <chenjiahan.jait@bytedance.com>
chenjiahan
changed the title
chenjiahan
changed the title
chenjiahan
approved these changes
May 13, 2024
chenjiahan
changed the title
2 tasks
2 tasks
This was referenced May 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, when we turned on css extract (by default), we used rspack's experiments.css function.
but there are lots of difference between experiments.css and mini-css-extract-plugin which makes migrate old application hard and has some bugs.
Related Links
Checklist