Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onboarding CLI: replace GitRepository flags with the new schema #3708

Merged
merged 2 commits into from
Dec 11, 2023
Merged

onboarding CLI: replace GitRepository flags with the new schema #3708

merged 2 commits into from
Dec 11, 2023

Conversation

waleedhammam
Copy link
Contributor

Closes #3707

What changed?

  • Remove deprecated values and replace with the newly inserted ones

Why was this change made?

  • Using deprecated values lead to issues with git GitRepositoryConfig

How was this change implemented?

  • Remove repoBranch, repoUrl, repoPath from Config and replace in code with corresponding values

How did you validate the change?

  • Explain how a reviewer can verify the change themselves

gitops bootstrap in interactive mode should work ok

  • Integration tests -- what is covered, what cannot be covered;
    or, explain why there are no new tests

  • Unit tests -- what is covered, what cannot be covered; are
    there tests that fail without the change?
    updated some of the unit tests

Release notes

Documentation Changes

Other follow ups

@waleedhammam waleedhammam added exclude from release notes Use this label to exclude a PR from the release notes bug_regression bugs found in regression testing done on main labels Dec 11, 2023
@waleedhammam waleedhammam removed the bug_regression bugs found in regression testing done on main label Dec 11, 2023
enekofb
enekofb approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@enekofb enekofb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for addressing it so quickly

@waleedhammam waleedhammam merged commit bfeadee into main Dec 11, 2023
10 checks passed
@waleedhammam waleedhammam deleted the cli-hotfix branch December 11, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enekofb enekofb enekofb approved these changes

Assignees
No one assigned
Labels
exclude from release notes Use this label to exclude a PR from the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cannot bootstrap flux interactive with error scheme "" is not supported
2 participants
@waleedhammam @enekofb