Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix monitoring docs #3656

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Fix monitoring docs #3656

merged 1 commit into from
Nov 22, 2023

Conversation

opudrovs
Copy link
Contributor

@opudrovs opudrovs commented Nov 21, 2023 •
edited
Loading

Closes #3653

  • Fixed broken links to the weave-gitops-quickstart/monitoring folder.

  • Removed extra spaces.

  • Fixed capitalization of Weave GitOps (switched to using the official capitalization in text, descriptions, and comments).

  • Minor spelling fixes.

  • Generated protobuf definitions.

@opudrovs opudrovs added type/documentation Improvements or additions to documentation exclude from release notes Use this label to exclude a PR from the release notes and removed type/documentation Improvements or additions to documentation labels Nov 21, 2023
@opudrovs opudrovs force-pushed the 3653-fix-monitoring-docs branch 6 times, most recently from fdf31de to 8891c39 Compare November 22, 2023 02:17
@opudrovs opudrovs marked this pull request as ready for review November 22, 2023 03:10
@opudrovs opudrovs requested a review from a team November 22, 2023 03:10
@opudrovs opudrovs force-pushed the 3653-fix-monitoring-docs branch 2 times, most recently from a59b8a6 to a9cd91f Compare November 22, 2023 10:57
enekofb
enekofb approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@enekofb enekofb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking the time for this 🙏

just a small link change suggestion

@opudrovs
Fix broken links, spaces, and capitalization of Weave GitOps (#3653)
6a1fea1 
Minor spelling fixes.

Generate protobuf definitions.
@opudrovs opudrovs merged commit 9f66dd5 into main Nov 22, 2023
10 checks passed
@opudrovs opudrovs deleted the 3653-fix-monitoring-docs branch November 22, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enekofb enekofb enekofb approved these changes

Assignees
No one assigned
Labels
exclude from release notes Use this label to exclude a PR from the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix monitoring docs
2 participants
@opudrovs @enekofb