Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove GitOps Run components from WGE #3582

Merged
merged 13 commits into from
Nov 7, 2023
Merged

Conversation

yiannistri
Copy link
Collaborator

@yiannistri yiannistri commented Nov 2, 2023

Closes #3514

What changed?
Removed GitOps Run-related code from WGE. In doing so, I've had to also bump the following dependencies:

  • sigs.k8s.io/controller-runtime from 0.14.6 to 0.15.1
  • github.com/external-secrets/external-secrets from 0.7.0 to 0.9.3
  • sigs.k8s.io/cluster-api from v1.4.1 to v1.5.1
  • k8s.io/api from v0.26.8 to v0.27.7
  • k8s.io/cli-runtime from v0.26.3 to v0.26.8
  • k8s.io/client-go from v0.26.3 to v0.27.7

Why was this change made?
GitOps Run has been deprecated and WGE still references old code.

How did you validate the change?

  • Explain how a reviewer can verify the change themselves

  • Integration tests -- what is covered, what cannot be covered;
    or, explain why there are no new tests
    No integration tests needed, this PR removes obsolete code.

  • Unit tests -- what is covered, what cannot be covered; are
    there tests that fail without the change?
    No unit tests needed, this PR removes obsolete code.

Release notes
TBD

Documentation Changes
Already made.

Other follow ups
None.

@yiannistri yiannistri added the exclude from release notes Use this label to exclude a PR from the release notes label Nov 2, 2023
@yiannistri yiannistri marked this pull request as ready for review November 6, 2023 13:55
@yiannistri yiannistri merged commit 8645a44 into main Nov 7, 2023
10 checks passed
@yiannistri yiannistri deleted the update-weave-gitops branch November 7, 2023 09:16
@foot foot mentioned this pull request Nov 10, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from release notes Use this label to exclude a PR from the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checklist for Deprecating GitOps Run
3 participants