Add tenant field to Explorer objects #3580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpellizzari
added
enhancement
jpellizzari
requested review from
enekofb and
opudrovs
and removed request for
enekofb
|
@jpellizzari could you expand what is the background problem around tenants? ( you could safely assume little knowledge on tenancy implementation details from my side 🤣 ) |
@enekofb Same! I don't know what it is for and why someone would use it. Our docs are very sparse on this. |
jpellizzari
force-pushed
the
jp-obj-tenant
branch
2 times, most recently
from
fcaf765
to
7fa68ab
Compare
opudrovs
reviewed
Nov 9, 2023
pkg/query/server/server.go
Outdated
| for _, ns := range namespaces { | ||
| if ns.GetName() == obj.Namespace { | ||
| obj.Tenant = ns.Labels["toolkit.fluxcd.io/tenant"] | ||
|
|
There was a problem hiding this comment.
An empty line.
And maybe we could add a break statement here?
jpellizzari
force-pushed
the
jp-obj-tenant
branch
2 times, most recently
from
9eee999
to
44bf990
Compare
jpellizzari
force-pushed
the
jp-obj-tenant
branch
from
44bf990
to
d4e0797
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3299
Populates the
.tenantcolumn using the existing machinery. This is a temporary fix to get parity with existing views.Currently, we don't have a list of namespaces stored in the database that we can easily look up.
A possible long-term solution would be to watch namespaces and store a table of namespaces and tenants for a faster lookup