Rework 'Message' column in Explorer for Apps page consistency #3576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpellizzari
force-pushed
the
3568-explorer-msg
branch
from
402c373
to
5410087
Compare
jpellizzari
requested review from
AlinaGoaga,
TheGostKasper,
joshri,
opudrovs and
enekofb
jpellizzari
force-pushed
the
3568-explorer-msg
branch
from
5410087
to
0bb1480
Compare
opudrovs
approved these changes
Oct 31, 2023
| @@ -86,7 +91,15 @@ const TemplatesDashboard: FC<{ | |||
| extraColumns={[ | |||
| { | |||
| label: 'Type', | |||
| value: 'templateType', | |||
| value: o => { | |||
| console.log(o); | |||
TheGostKasper
approved these changes
Oct 31, 2023
jpellizzari
force-pushed
the
3568-explorer-msg
branch
from
0bb1480
to
380a5f1
Compare
added 3 commits
November 1, 2023 10:07
We want to pull the .message from the Ready condition, as it probably contains the most helpful error/success message for the user.
Making this closer to parity with the old Applications view
jpellizzari
force-pushed
the
3568-explorer-msg
branch
from
380a5f1
to
a487833
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3568
Closes #3569
Closes #3572
Fixes some issues related to the
Messagefield in Explorer.First, changes the conditions logic to use the
Readycondition to get a better error message (more consistent with Applications):Second, it truncates large values for the
messagefield. Before:After:
Lastly, fixes an issue where the
Templatesview had some irrelevant/weird columns. RemovedStatus,Message,Tenantin favor ofDescription.