stick to wego-admin admin user in gitops bootstrap command #3567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waleedhammam
added
the
exclude from release notes
enekofb
approved these changes
Nov 2, 2023
enekofb
reviewed
Nov 2, 2023
| @@ -95,7 +95,6 @@ func TestBootstrapCmd(t *testing.T) { | |||
| flags: []string{kubeconfigFlag, | |||
| "--version=0.33.0", | |||
There was a problem hiding this comment.
please update the version and run it so we keep it for ensuring some acceptance
enekofb
reviewed
Nov 2, 2023
| @@ -7,8 +7,8 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| installSuccessMsg = "WGE v%s is installed successfully\nYou can visit the UI at https://%s/" | |||
| portforwardMsg = "WGE v%s is installed successfully. To access the dashboard, run the following command to create portforward to the dasboard local domain http://localhost:8000" | |||
| installSuccessMsg = "WGE v%s is installed successfully\nYou can visit the UI at https://%s/ . admin username: `wego-admin`" | |||
There was a problem hiding this comment.
I think we could review this part to make it clearer the info: may be a different msg.
|
Regarding the docs , luckily nothing refers this part |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3506
What changed?
due to hardcoded rbacs to
wego-adminusername as admin hereIt's a limitation to create another user to be the admin
It would be difficult to replicate the permission for admin user and seems it's not intended to be that way in the code
How was this change implemented?
wego-adminHow did you validate the change?
do
gitops bootstrapand the wizard shall not ask for username and give indication that it'll bewego-adminIntegration tests -- what is covered, what cannot be covered;
or, explain why there are no new tests
Unit tests -- what is covered, what cannot be covered; are
there tests that fail without the change?
Release notes
Documentation Changes
Other follow ups