Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Gitopssets UI to use OSS endpoints for querying/suspend/sync #3556

Merged
merged 5 commits into from
Nov 14, 2023

Conversation

foot
Copy link
Collaborator

@foot foot commented Oct 27, 2023

What changed?

Remove all the dedicated gitopssets endpoints:

  • GET /v1/gitopssets
  • GET /v1/namespaces/{namespace}/gitopssets/{name}
  • GET /v1/namespaces/{namespace}/gitopssets/{name}/inventory
  • PATCH /v1/namespaces/{namespace}/gitopssets/{name}/suspend
  • PATCH /v1/namespaces/{namespace}/gitopssets/{name}/sync

Add GitOpsSet as a supported kind to OSS's query system endpoints

Use OSS equivalent endpoints instead.

Behaviour changes?

Yes!

  • We don't try and report the health of confimaps anymore etc as "⚠️ unknown" as we delegate to the health checker system.
  • The OSS querier that we are now using for listing gitopssets in the table view works slightly differently to the non-explorer EE querier. You will only see GitOpsSets in namespaces that you have permissions to read the classic list of flux resources as well. This may cause issues in some tenancy setups.
    • Workaround: enable the explorer

Why was this change made?

API Cleanup

How was this change implemented?

Removing all the gitopssets endpoints and mopped up the UI

How did you validate the change?

  • Explain how a reviewer can verify the change themselves

  • tilt up

  • Test gitopssets sync / suspend / graph / events / yaml etc

  • Edit tools/dev-values.yaml and disable the explorer and check that gitopssets listing table still works

Release notes

Documentation Changes

Other follow ups

@foot foot added the exclude from release notes Use this label to exclude a PR from the release notes label Oct 27, 2023
@foot
Copy link
Collaborator Author

foot commented Oct 27, 2023

Workaround: enable the explorer

Perhaps we could actually enable the explorer + gitopssets for the next release by default, wdyt @enekofb ?

@foot foot marked this pull request as ready for review October 27, 2023 14:15
@foot foot requested a review from AlinaGoaga October 27, 2023 14:15
@enekofb
Copy link
Contributor

enekofb commented Oct 27, 2023

Workaround: enable the explorer

Perhaps we could actually enable the explorer + gitopssets for the next release by default, wdyt @enekofb ?

Go go go 🚀

Copy link
Contributor

@AlinaGoaga AlinaGoaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great! 🥳

@foot foot merged commit e789cb9 into main Nov 14, 2023
10 checks passed
@foot foot deleted the upgrade-weave-gitops-main branch November 14, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from release notes Use this label to exclude a PR from the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants