CLI: add support for namespace other than flux-system

[waleedhammam]

Closes #3473

What changed?

• add support for namespace other than flux-system

How did you validate the change?

• Unit tests

How to test?

• bootstrap flux in a namespace of your choice (test-namespace)

  flux bootstrap git \
    --url=ssh://git@<host>/<org>/<repository> \
    --branch=main \
    --private-key-file=<path/to/private.key> \
    --password=<key-passphrase> \
    --path=clusters/my-cluster
   -n test-namespace

• start the CLI bootstrap process using this namespace gitops bootstrap -n test-namespace
• this means every command runs from this CLI will address test-namespace namespace instead of flux-system
• note: entitlement aswell will be in this namespace
• note: starting without namespace will take flux-system by default

Release notes

Documentation Changes

Other follow ups

[enekofb]

looks good!

missing acceptance and testing myself under #3542

added also some other comments

[enekofb]

is this flag different to

weave-gitops-enterprise/cmd/gitops/app/root/cmd.go

Line 120 in 3a2548b

rootCmd.PersistentFlags().StringP("namespace", "n", defaultNamespace, "The namespace scope for this operation")

?

[waleedhammam]

I'm overriding it to be able to pass it to the commands
The root app doesn't refer it to a pointer or variable

[enekofb]

where is flux-system resolved if no namespace is set?

[waleedhammam]

In the flag itself, if it's not passed, then automatically set to flux system

[enekofb]

when testing i get this error where i could see that the namespace has changed but i believe the kusktomization might be require also to change?

► verifying flux reconcillation in namespace: acceptance
    cmd_acceptance_test.go:148: 
        Expected
            <*errors.errorString | 0x140000d2fd0>: 
            cannot execute bootstrap: cannot execute 'checking flux': flux bootstrapped error: failed to reconcile flux source acceptance:flux-system: ✗ gitrepositories.source.toolkit.fluxcd.io "flux-system" not found
            . please bootstrap Flux: more info https://fluxcd.io/flux/installation
            {
                s: "cannot execute bootstrap: cannot execute 'checking flux': flux bootstrapped error: failed to reconcile flux source acceptance:flux-system: ✗ gitrepositories.source.toolkit.fluxcd.io \"flux-system\" not found\n. please bootstrap Flux: more info https://fluxcd.io/flux/installation",
            }
        to be nil
    cmd_acceptance_test.go:256: "level"=0 "msg"="deleted object" "name"="weave-gitops-enterprise-credentials" "ns"="acceptance" "kind"="Secret"

using the acceptance test aeb36f8#diff-82c4512096c6663a9b8f6901f0bd9c7e88088210551b054be8fbc3ca2ca0da1c

[waleedhammam]

Closing as it's not doable to use another namespace as it's hard-coded in flux
PR became obsolete