Adds initial gitopssets inventory endpoint #3522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foot
commented
Oct 29, 2023
ranatrk
force-pushed
the
gitopssets-inventory-stuff
branch
3 times, most recently
from
58316f6
to
ac4de22
Compare
ranatrk
added
bug
|
go.mod needs to be updated once weaveworks/weave-gitops#4090 is merged |
bigkevmcd
reviewed
Nov 2, 2023
ranatrk
force-pushed
the
gitopssets-inventory-stuff
branch
3 times, most recently
from
a9493f0
to
99d4207
Compare
ranatrk
force-pushed
the
gitopssets-inventory-stuff
branch
from
f09f305
to
604ecc7
Compare
ranatrk
force-pushed
the
gitopssets-inventory-stuff
branch
from
7f3c53e
to
d91c18d
Compare
foot
force-pushed
the
gitopssets-inventory-stuff
branch
from
d91c18d
to
bd63ef7
Compare
- Adds initial gitopssets inventory endpoint
…entory entries and their children Add health checker to gitopssets server object
- Not sure best way to compare inventory
…et reconciled objects endpoint
…ieving gitopsset response with those params
- Adds initial gitopssets inventory endpoint
…entory entries and their children Add health checker to gitopssets server object
fix rebase issues
ranatrk
force-pushed
the
gitopssets-inventory-stuff
branch
from
bd63ef7
to
84a1379
Compare
ranatrk
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on weaveworks/weave-gitops#4090
Closes #2776
What changed?
/v1/namespaces/NAMESPACE/gitopssets/GITOPSSET_NAME/inventoryWhy was this change made?
How was this change implemented?
How did you validate the change?
Explain how a reviewer can verify the change themselves
starting wge and adding a gitopssets, The UI can be used to navigate between the gitopssets created and their resources
Unit tests -- what is covered, what cannot be covered; are
there tests that fail without the change?
Release notes
Add gitopssets inventory endpoint
Documentation Changes
Other follow ups