Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cluster_namespace from non-cluster queries #3403

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

foot
Copy link
Collaborator

@foot foot commented Sep 26, 2023

  • We use a concatenated clusterName e.g. "default/my-cluster" in all parts of the system, keep it like this for now
  • Fixes workspaces querying as we were not passing in cluster_namespace to those requests etc.

Reverts some changes made in #3288 -- when we made those changes we did not split and then re-merge the "clusterNamespace/clusterName" string.

- We use a concatenated clusterName e.g. "default/my-cluster" in all
  parts of the system, keep it like this for now
@foot foot added the exclude from release notes Use this label to exclude a PR from the release notes label Sep 26, 2023
@foot foot marked this pull request as ready for review September 26, 2023 08:50
@foot foot requested a review from sarataha September 26, 2023 08:50
Copy link
Contributor

@sarataha sarataha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@foot foot merged commit b643619 into main Sep 26, 2023
10 checks passed
@foot foot deleted the remove-cluster-from-url-path branch September 26, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from release notes Use this label to exclude a PR from the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants