Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix styling naming collision #3302

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Fix styling naming collision #3302

merged 2 commits into from
Sep 7, 2023

Conversation

jpellizzari
Copy link

@jpellizzari jpellizzari commented Sep 6, 2023 •
edited
Loading

Fixes an issue where makeStyles and styled-components use the same class name for totally different things.

Notice the .jss3 duplicated class name.

Screenshot from 2023-09-06 10-12-29

@jpellizzari jpellizzari added the bug Something isn't working label Sep 6, 2023
@jpellizzari jpellizzari added bug Something isn't working and removed bug Something isn't working labels Sep 6, 2023
@jpellizzari jpellizzari marked this pull request as ready for review September 6, 2023 17:19
joshri
joshri approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@joshri joshri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BIG thumbs up 👍

@yiannistri yiannistri merged commit 177d822 into main Sep 7, 2023
10 checks passed
@yiannistri yiannistri deleted the jp-fix-collision branch September 7, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshri joshri joshri approved these changes

@TheGostKasper TheGostKasper Awaiting requested review from TheGostKasper

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpellizzari @joshri @yiannistri