Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

Build with -Wunused, -Wall and -Werror #18

Merged
merged 1 commit into from
Mar 8, 2017

Conversation

schu
Copy link
Contributor

@schu schu commented Feb 16, 2017

Also, fix what looks like a typo in the is_ipv4_mapped_ipv6 branch of
kretprobe__tcp_v6_connect.

@schu
Copy link
Contributor Author

schu commented Feb 16, 2017

@alban @iaguis please take a look. I'm not sure about the typo (i.e. is &t4 correct here?) and if we should keep a comment regarding IPPROTO_TCP.

@alban
Copy link
Contributor

alban commented Feb 16, 2017

This looks correct to me. Does it work on a 4.4 kernel?

@schu schu force-pushed the schu/remove-unused branch 2 times, most recently from bde57e1 to eb78079 Compare February 16, 2017 16:14
@schu
Copy link
Contributor Author

schu commented Feb 16, 2017

Does it work on a 4.4 kernel?

We run the tests on 4.4.45.

@alban
Copy link
Contributor

alban commented Feb 16, 2017

LGTM

@alban
Copy link
Contributor

alban commented Feb 23, 2017

This needs to be rebased & recompiled to resolve the conflict.

Also, fix what looks like a typo in the `is_ipv4_mapped_ipv6` branch of
`kretprobe__tcp_v6_connect`.
@schu schu force-pushed the schu/remove-unused branch from eb78079 to 2056098 Compare February 24, 2017 07:06
@schu
Copy link
Contributor Author

schu commented Feb 24, 2017

Rebased.

@iaguis iaguis merged commit 1984308 into weaveworks:master Mar 8, 2017
@schu schu deleted the schu/remove-unused branch March 8, 2017 10:40
sunhay added a commit to DataDog/tcptracer-bpf that referenced this pull request Feb 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants