Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable scroll locking on the terminal #1932

Merged
merged 3 commits into from
Nov 1, 2016
Merged

Conversation

foot
Copy link
Contributor

@foot foot commented Oct 18, 2016

Fixes #1481

@foot
Copy link
Contributor Author

foot commented Oct 18, 2016

@2opremio could you give this a quick test please!

@2opremio
Copy link
Contributor

Sure, I'll do that before EOD.

On Tue, Oct 18, 2016 at 3:51 PM, Simon notifications@github.com wrote:

@2opremio https://github.com/2opremio could you give this a quick test
please!


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1932 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACQOJAJ7WNxryAN62-AokQtKV42IIf2cks5q1M7GgaJpZM4KZ0Dv
.

@davkal
Copy link
Contributor

davkal commented Oct 18, 2016

If I run the following and try to scroll up, the screen goes all black (before the fix it would jump around but show output.

while true; do find /etc; done                                

@foot
Copy link
Contributor Author

foot commented Oct 18, 2016

Good one, that blows through the scroll back nice and quickly..

@2opremio
Copy link
Contributor

I am missing a side bar to indicate where am I in the history.

@2opremio
Copy link
Contributor

Also, I would expect scrolling to happen when selecting text and moving the mouse up. That is:

@foot
Copy link
Contributor Author

foot commented Oct 20, 2016

Scrollbars are a nice to have, mentioned in #1940.

Scrolling up as we drag up is an interesting one. I'll mention it in that issue too.

@foot
Copy link
Contributor Author

foot commented Oct 20, 2016

But you're looking for a way to export the contents of the terminal somehow. Other (less ideal but still) options:

  • Copy terminal contents to clipboard
  • Show terminal contents in some other mode that allows for better selection. (textarea/plain <p>s)

@foot
Copy link
Contributor Author

foot commented Oct 20, 2016

Issue w/ this: cannot make a selection after having scrolled up.

@davkal
Copy link
Contributor

davkal commented Oct 20, 2016

Scrolling up works well, and the position stays there. Selections dont work when scrolled up, but that's mentioned. Definitely an improvement. LGTM

@davkal davkal assigned foot and unassigned davkal and 2opremio Oct 20, 2016
foot added 3 commits November 1, 2016 11:44
aka, scroll locking. Allows you to scroll back through logs without new
log data dragging the scroll back down to the next entries as they come
in.
@foot foot force-pushed the 1481-scroll-lock-terminals branch from bed9eec to a381e3c Compare November 1, 2016 14:46
@foot foot merged commit 794b9c9 into master Nov 1, 2016
@foot foot deleted the 1481-scroll-lock-terminals branch November 1, 2016 15:33
@2opremio
Copy link
Contributor

2opremio commented Nov 1, 2016

Selections dont work when scrolled up, but that's mentioned

Is there an issue for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants