Fix path to main #58
Open
Fix path to main #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
cd libfrom push script, which caused index.js to end up in the root of the package.This caused problems for us when trying to switch from webpack to vite. Apparently webpack manages to find
index.jseven if the path in package.json does not match the file location, but vite does not. We have a dependency to@cabify/prom-reactwhich has a dependency to promjs.This has been tested by publishing to npm with a different package name and overriding in our project.
The fix was suggested by @smithamax
Fixes #23