Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
We've started using your package (which is great, by the way, thank you!) recently, and I noticed that it started bloating the JS file that it gets included into. Digging into it a bit further, I saw that this package was importing lodash components as
import {foo, bar} from 'lodash'
, which imports the entire lodash package. I've changed the imports to bewhich imports only the specific modules required. Doing this should reduce the file size footprint of this package :).
utils.js
file. In this particular instance I replaced thelodash.keys
method withObject.keys
andlodash.map
with theArray.map
function. There are a few other instances this could be done, such as in the usage offilter
,reduce
, and a few other methods, but I thought I'd get this merged in first and return to these later.Thanks, and let me know if I missed anything or you have any questions!