Fix slow performance due to excessive calls to find-namespace
#234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit messages of this repository should follow the seven rules of a great Git commit message, as mentioned in the project's contributing guidelines. It looks like there's a few issues with the commit messages in this pull request:
|
LuisThiamNye
force-pushed
the
luistn/fix-perf-find-namespace
branch
from
d199bc9 to
95ceb97
Compare
weavejester
requested changes
Jun 11, 2021
Ensure this function is only called once per reformat request. Otherwise, it is called many times per line, significantly slowing down the formatter.
LuisThiamNye
force-pushed
the
luistn/fix-perf-find-namespace
branch
from
95ceb97 to
81bb59b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the
find-namespacefunction is only called once per reformat request. Otherwise, it is called many times per line, significantly slowing down the formatter.Addresses #226