Optional add button for nested tables #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… nested tables for cases where the nested table is pretty much read only info.
… set to true as well.
|
🎉 shipit! |
jamesmk
previously requested changes
Sep 23, 2019
There was a problem hiding this comment.
Looks good, can you document the option here:
https://github.com/wearefine/fae/blob/master/docs/helpers/partials.md#nested-table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #496
Found that this was a pretty simple change to add an optional argument that can be used to disable the add button and the "add some" link on a nested table. This should be a lot faster and easier to use than creating a custom table just to override the default behavior.