80330 security fixes #488
Merged
80330 security fixes #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sweet! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent vertical privilege escalation
Users with the role of admins could potentially set their role as super admin by abusing the
togglemethod provided for boolean attributes. Stricter definitions were added totoggleto make sure this doesn't happen.More toggle abuse
togglecould also be used to on non-boolean attributes, which could lead to other potential security issues. Method is now available for booleans only.togglealso exposed the existence of classes but returning a 500 when a class did not exist. Missing classes now return a 401 inline with unauthorized classes.Brute-force protection
Currently Fae has no brute-force protection. This also enables Devise's lockable feature which will lock accounts after 5 failed attempts to log in. Accounts unlock after an hour or via emailed instructions.