Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #409 - fix bugs in stripValidation() #426

Merged
merged 1 commit into from
Nov 2, 2018

Conversation

aleksb
Copy link
Contributor

@aleksb aleksb commented Sep 11, 2018

Fixes issue #409

In my case this issue manifested in being able to update users only in Firefox, but not Chrome or Edge.

Two bugs were fixed:

  • Deleting an item from the array "skips over" the next item because the array gets shortened
  • jQuery.attr leads to double-stringifying of objects which Judge chokes on (but apparently not in Firefox)

@jamesmk
Copy link
Member

jamesmk commented Oct 26, 2018

Thanks for the PR! I'll verify the bugs fixed soon and get this thing merged.

@jamesmk jamesmk merged commit 831caa6 into wearefine:master Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants