allow blank labels for fae_content_form

[andrewdang17]

This is just a quick fix so I can get ticket done for a client this week. I think later on all that logic in _content_form.html.slim should be refactored out to be separate from the partial so that you just have to pass an options in rather than every possible variable since everything is a bit dependent on each other right now and relies on a lot of conditionals.

[jamesmk]

@andrewdang17 We're starting to spread the label logic all over this file. The label_adjusted assignment on line 13 is where the full label get's built, so I think that's where the conditional logic should live. There should be no need to execute that logic if we're just setting it to false later.

[andrewdang17]

I agree I just did it this way because I didn't want to add more if/unless statements to lines 12-22 or have to wrap the whole thing in an if statement

[jamesmk]

I find this line difficult to interpret. If we focus on supporting label: false, then it could look something like:

has_label = !local_assigns[:label].eql?(false)

This is a pattern we've using in other partials too.

[andrewdang17]

Nice that looks better. label: false was the only way to remove the label for simpleform hence the check for false or an empty string

[andrewdang17]

@jamesmk what do you about using this instead?
has_label = ![false, ''].include?(local_assigns[:label])

The problem with your way is that if label: false, then !local_assigns[:label] will return true when really it should be false.

[andrewdang17]

@jamesmk updated