Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#70630 - show action should return a 404 by default #339

Merged
merged 1 commit into from
Nov 2, 2017
Merged

#70630 - show action should return a 404 by default #339

merged 1 commit into from
Nov 2, 2017

Conversation

jamesmk
Copy link
Member

@jamesmk jamesmk commented Oct 27, 2017

We don't provide a show action in Fae::BaseController, so let's return a 404 instead of an error. Users can override show action per resource as needed.

tshedor
tshedor approved these changes Nov 2, 2017
View reviewed changes
Copy link
Contributor

@tshedor tshedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this a lot

@jamesmk jamesmk merged commit 118eadb into master Nov 2, 2017
@jamesmk jamesmk deleted the 70630-404 branch November 2, 2017 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tshedor tshedor tshedor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesmk @tshedor