Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #344 #352

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixed issue #344 #352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5874c0a
Issue "https://github.com/we-dance/platform/issues/344" fixed
yulluone Mar 16, 2023
a6a3a8a
Merge branch 'we-dance:main' into main
yulluone Mar 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion components/TBanner.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,23 @@
class="order-3 mt-2 flex-shrink-0 w-full sm:order-2 sm:mt-0 sm:w-auto"
>
<a
v-if="link"
:href="link"
target="_blank"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break the social media buttons. They suppose to open new window.

target=""
class="flex items-center justify-center px-4 py-2 border border-transparent rounded-md shadow-sm text-sm font-medium text-indigo-600 bg-white hover:bg-indigo-50"
@click="$emit('input', 'yes')"
>
{{ action }}
</a>
<NuxtLink
v-else-if="to"
target=""
class="flex items-center justify-center px-4 py-2 border border-transparent rounded-md shadow-sm text-sm font-medium text-indigo-600 bg-white hover:bg-indigo-50"
@click="$emit('input', 'yes')"
:to="to"
>
{{ action }}
</NuxtLink>
</div>
<div class="order-2 flex-shrink-0 sm:order-3 sm:ml-3">
<button
Expand Down Expand Up @@ -96,6 +106,10 @@ export default {
type: String,
default: '',
},
to: {
type: String,
default: '',
},
},
}
</script>
2 changes: 1 addition & 1 deletion layouts/default.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
desktop="Upload your photo"
mobile="Upload your photo"
action="Upload"
link="https://wedance.vip/settings?tab=profile"
to="/settings"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It suppose to open profile tab in settings

/>
<TBanner
v-if="false"
Expand Down