-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: update to test uploading a source code
The `adm-zip` has some flaw so we cannot generate good JS files (see cthackers/adm-zip#526). Therefore I do a patch. We should remove the patch once the issue is fixed.
- Loading branch information
Showing
4 changed files
with
45 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
diff --git a/zipFile.js b/zipFile.js | ||
index 234f6cdbfa954c077c31000459e0d7c22c1533f4..39e23f1a9662b2ccff6eef96761bca0f93c9998e 100644 | ||
--- a/zipFile.js | ||
+++ b/zipFile.js | ||
@@ -294,7 +294,10 @@ module.exports = function (/*Buffer|null*/ inBuffer, /** object */ options) { | ||
|
||
mainHeader.size = 0; | ||
mainHeader.offset = 0; | ||
- totalEntries = 0; | ||
+ | ||
+ // A fix of https://github.com/cthackers/adm-zip/issues/526. | ||
+ // TODO: Drop the patch once the issue is resolved. | ||
+ let totalEntries = 0; | ||
|
||
for (const entry of this.entries) { | ||
// compress data and set local and entry header accordingly. Reason why is called first |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters