Adjust project structure and simplify user messages. #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdhongtw
added
documentation
- Extract UI message box logic from core part - Remove message for key changed related event - Replace some long message with two existing, shorter message - Avoid double confirm for cache delete operation - No need to translate error for pre-condition violation
The final part for my DDD project structure.
wdhongtw
force-pushed
the
feat-simplify-message
branch
from
a7f044a to
10971f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust project structure to reflect the logic hierarchy and my mental model
core.ts: the core part where the core business logic, e.g. KeyManager, be locatedadapter/*.ts: output adapters, e.g. implementation for git and gpg operationscommon/*.ts: the shared part that can be depended on by all modulesextension.ts: where the main module and implicit router(input adapter) lives.Simplify messages that will be shown to our users