Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On white background image not colored #8

Closed
NikoLichi opened this issue Mar 22, 2024 · 7 comments
Closed

On white background image not colored #8

NikoLichi opened this issue Mar 22, 2024 · 7 comments

Comments

@NikoLichi
Copy link

Hi Wouter,

I am trying to find the best way to see matching colors and have tried both white and black backgrounds. However, with the same setup on a white background, there are no colors; please see the attached figure.

68_T00_GeneCvsNovo

Is this a bug?

The code I am using is:

./kyber -t 16 \
--input $FILEIN_1 $FILEIN_2 \
--phred \
--background white \
--color red blue \
--output ${PREFIX}_GeneCvsNovo.png

Thanks and all the best,
Niko

@NikoLichi
Copy link
Author

A small add-on: when using the --normalize option instead of --phred, the code works well.
Please see figure
68_T00_GeneCvsNovo

Would you recommend the phred or the normalized option to check technical samples?

Best,
Niko

@wdecoster
Copy link
Owner

Hmm, this looks like a bug. Just to be sure, everything is alright when you use the black background?

@NikoLichi
Copy link
Author

Yes, everything is normal see the attached figure.

Do you have any suggestions on the phred or the normalized option to check technical replicates?

65_T00_GeneCvsNovo

@NikoLichi
Copy link
Author

Hi Wouter,

I was checking the files again and discovered that what I thought was black is actually a high saturation. I meant, if you make Zoom on the image with white background it is possible to see the red, blue and purple colors.

However, I would think that even in high saturation the overlapping colors should be kept, in this case purple and not black, or?

So, I guess Kyber is doing what it should! But the issue with the black color of overlapping points is weird to me.

All the best,
Niko

wdecoster added a commit that referenced this issue Nov 16, 2024
@wdecoster
Copy link
Owner

Finally fixed, will make a new release soon

@NikoLichi
Copy link
Author

This is great! Thanks, Wouter.

@wdecoster
Copy link
Owner

Please let me know if you have other feedback :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants