Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove id on help link #131

Merged
merged 1 commit into from
Mar 20, 2025
Merged

Remove id on help link #131

merged 1 commit into from
Mar 20, 2025

Conversation

rosalieper
Copy link
Contributor

Updated readme file with changelog

Updated readme file with changelog
@deer-wmde
Copy link
Contributor

Ah I suppose the link gets overwritten from the JS that gets loaded off-repo and removing the id prevents that? clever workaround! ✨

suggestion: I think adding a HTML comment there in the file would help us in the future to be aware of this, otherwise we might easily forget that this is whats happening

@rosalieper rosalieper merged commit e3bc5af into main Mar 20, 2025
3 checks passed
@rosalieper
Copy link
Contributor Author

rosalieper commented Mar 20, 2025

suggestion: I think adding a HTML comment there in the file would help us in the future to be aware of this, otherwise we might easily forget that this is whats happening.

Oops! I had already clicked the merge button before reading the suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants