-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Clannad theme #8851
Add Clannad theme #8851
Conversation
https://github.com/lemorage/sublime-clannad-theme/blob/main/packages.json is not required as metadata (description, author) are read from github repo info directly and version is read from tags. |
@deathaxe Shall I delete it or just leave it out there? |
It's useless. I'd remove it to avoid confusion. |
alright. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: SUCCESS
Repo link: Clannad Theme
Packages added:
- Clannad Theme
Processing package "Clannad Theme"
- All checks passed
The type of package you're adding here is, in the Sublime Text parlance, a "color scheme" and not a "theme". A theme is purely for the UI of the application, the color scheme is for syntax highlighting. So please refer to your package as "Clannad color scheme", also in your readme etc. |
@braver Ah, I'll make the corresponding changes. There was a theme file I hadn't included in my repo. Thanks for clarifying. |
Ah, in that case it's both a theme and a color scheme, excellent. Please add "theme" as one of the labels. |
sure! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: SUCCESS
Repo link: Clannad Theme
Packages added:
- Clannad Theme
Processing package "Clannad Theme"
- All checks passed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: SUCCESS
Repo link: Clannad Theme
Packages added:
- Clannad Theme
Processing package "Clannad Theme"
- All checks passed
My package is Clannad Theme
There are no packages like it in Package Control.