Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Clannad theme #8851

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Add Clannad theme #8851

merged 1 commit into from
Dec 4, 2023

Conversation

lemorage
Copy link
Contributor

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

My package is Clannad Theme

There are no packages like it in Package Control.

@deathaxe
Copy link
Contributor

https://github.com/lemorage/sublime-clannad-theme/blob/main/packages.json is not required as metadata (description, author) are read from github repo info directly and version is read from tags.

@lemorage
Copy link
Contributor Author

@deathaxe Shall I delete it or just leave it out there?

@deathaxe
Copy link
Contributor

It's useless. I'd remove it to avoid confusion.

@lemorage
Copy link
Contributor Author

alright.

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: Clannad Theme

Packages added:
  - Clannad Theme

Processing package "Clannad Theme"
  - All checks passed

@braver
Copy link
Collaborator

braver commented Dec 2, 2023

The type of package you're adding here is, in the Sublime Text parlance, a "color scheme" and not a "theme". A theme is purely for the UI of the application, the color scheme is for syntax highlighting. So please refer to your package as "Clannad color scheme", also in your readme etc.

@lemorage
Copy link
Contributor Author

lemorage commented Dec 2, 2023

@braver Ah, I'll make the corresponding changes. There was a theme file I hadn't included in my repo. Thanks for clarifying.

@braver
Copy link
Collaborator

braver commented Dec 3, 2023

Ah, in that case it's both a theme and a color scheme, excellent. Please add "theme" as one of the labels.

@lemorage
Copy link
Contributor Author

lemorage commented Dec 3, 2023

sure!

@lemorage lemorage reopened this Dec 3, 2023
Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: Clannad Theme

Packages added:
  - Clannad Theme

Processing package "Clannad Theme"
  - All checks passed

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: Clannad Theme

Packages added:
  - Clannad Theme

Processing package "Clannad Theme"
  - All checks passed

@braver braver merged commit eb9ab13 into wbond:master Dec 4, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants