Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GitHubFileFetcher Package. #8848

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

dennykorsukewitz
Copy link
Contributor

@dennykorsukewitz dennykorsukewitz commented Nov 13, 2023

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

My package is GitHubFileFetcher.
This package searches and fetches files from GitHub.

githubfilefetcher

There are no packages like it in Package Control.

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: GitHub File Fetcher

Packages added:
  - GitHub File Fetcher

Processing package "GitHub File Fetcher"
  - All checks passed

@dennykorsukewitz dennykorsukewitz marked this pull request as ready for review November 13, 2023 08:21
Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: GitHub File Fetcher

Packages added:
  - GitHub File Fetcher

Processing package "GitHub File Fetcher"
  - All checks passed

@dennykorsukewitz dennykorsukewitz changed the title Added GitHubFileFetcher. Added GitHubFileFetcher Package. Nov 20, 2023
@braver
Copy link
Collaborator

braver commented Dec 8, 2023

Is the list of possible repositories a "white list", ie. only repos in that list can be searched?

@braver
Copy link
Collaborator

braver commented Dec 8, 2023

In the main menu file, for any existing entries like "Preferences", "Package Settings", etc. please only provide the id. Otherwise you're effectively overriding the menu entry name/caption and mnemonic.

The Default.sublime-keymap file doesn't seem to exist in your repo?

@dennykorsukewitz
Copy link
Contributor Author

In the main menu file, for any existing entries like "Preferences", "Package Settings", etc. please only provide the id. Otherwise you're effectively overriding the menu entry name/caption and mnemonic.

The Default.sublime-keymap file doesn't seem to exist in your repo?

Ah good to know.
I fixed that all with dennykorsukewitz/Sublime-GitHubFileFetcher@622d267

@dennykorsukewitz
Copy link
Contributor Author

Is the list of possible repositories a "white list", ie. only repos in that list can be searched?

It is rather a list of already saved repos (from already searched repos).

You are looking for a repo. Either by the owner or directly by name.

Then you can get the desired file in the desired branch.

Finally, you are asked whether you want to save this repo.
This list of saved repos is then displayed each time.

This allows you to use your frequently used repos quickly.

@braver
Copy link
Collaborator

braver commented Dec 13, 2023

Nifty!

@braver
Copy link
Collaborator

braver commented Dec 13, 2023

Alright, let's ship this, but don't forget to tag a new release with your latest changes. Package Control only sees the tags on your repo, general commits won't deploy to end users.

@braver braver merged commit 7da8d17 into wbond:master Dec 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants