Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cssnext #5015

Merged
merged 2 commits into from
Dec 1, 2015
Merged

add cssnext #5015

merged 2 commits into from
Dec 1, 2015

Conversation

zhouwenbin
Copy link
Contributor

No description provided.

@FichteFoll
Copy link
Collaborator

  1. You'll need to change "branch": "master" to "tags": true and use tags to create releases and push valid semantic version tags to your repo. As mentioned in the docs, we no longer accepts branch-based releases for new packages.
  2. Please remove the package-metadata.json file from your repo. It is supposed to be auto-generated by Package Control on installation.
  3. Please remove all .pyc files from your repo and add them to .gitignore.
  4. Your Python code is copypasta'd and partly flawed, but I already ranted over it somewhere else and can't find it right now.
  5. sublime.packages_path() may not be available at the time you call it and just return None, making everything fail.
  6. Because you are invoking Node, you need a .no-sublime-package file.

@FichteFoll
Copy link
Collaborator

Actually, what is the difference to the original, https://github.com/sindresorhus/sublime-autoprefixer, in the first place?

zhouwenbin added a commit to zhouwenbin/sublime-cssnext that referenced this pull request Dec 1, 2015
@zhouwenbin
Copy link
Contributor Author

Thanks a lot.It contains autoprefixer and other useful plugn.http://cssnext.io/features/

@FichteFoll
Copy link
Collaborator

Okay, so one uses the autoprefixer node module, while yours uses postcss-cssnext, which actually also wrappes autoprefixer but does additional things. Correct?

You should really link cssnext.io in your readme.

FichteFoll added a commit that referenced this pull request Dec 1, 2015
@FichteFoll FichteFoll merged commit 58e9ae6 into wbond:master Dec 1, 2015
@zhouwenbin
Copy link
Contributor Author

Many thanks. I had link cssnext in the License section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants