Drop passwd from DebuggableHTTPHandler

DebuggableHTTPHandler does not use passwd directly.
wbond · Jan 27, 2024 · e5b8b40 · e5b8b40
1 parent 39d47c2
commit e5b8b40
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 5 deletions.
diff --git a/package_control/downloaders/urllib_downloader.py b/package_control/downloaders/urllib_downloader.py
@@ -299,7 +299,7 @@ def setup_opener(self, url, timeout):
                     user_agent=self.settings.get('user_agent')
                 ))
             else:
-                handlers.append(DebuggableHTTPHandler(debug=debug, passwd=password_manager))
+                handlers.append(DebuggableHTTPHandler(debug=debug))
             self.opener = build_opener(*handlers)
 
     def supports_ssl(self):

diff --git a/package_control/http/debuggable_http_connection.py b/package_control/http/debuggable_http_connection.py
@@ -15,8 +15,6 @@ class DebuggableHTTPConnection(HTTPConnection):
     _debug_protocol = 'HTTP'
 
     def __init__(self, host, port=None, timeout=socket._GLOBAL_DEFAULT_TIMEOUT, **kwargs):
-        self.passwd = kwargs.get('passwd')
-
         if 'debug' in kwargs and kwargs['debug']:
             self.debuglevel = 5
         elif 'debuglevel' in kwargs:

diff --git a/package_control/http/debuggable_http_handler.py b/package_control/http/debuggable_http_handler.py
@@ -17,11 +17,9 @@ def __init__(self, debuglevel=0, debug=False, **kwargs):
             self._debuglevel = 5
         else:
             self._debuglevel = debuglevel
-        self.passwd = kwargs.get('passwd')
 
     def http_open(self, req):
         def http_class_wrapper(host, **kwargs):
-            kwargs['passwd'] = self.passwd
             if 'debuglevel' not in kwargs:
                 kwargs['debuglevel'] = self._debuglevel
             return DebuggableHTTPConnection(host, **kwargs)