Skip to content

Commit

Permalink
Revert "Avoid some object copies"
Browse files Browse the repository at this point in the history
This reverts commit abb7799.

This change caused explicit data from JSON to be overwritten with
fallback defaults.
  • Loading branch information
deathaxe committed Aug 21, 2022
1 parent aede06d commit a8262a9
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions package_control/providers/repository_provider.py
Original file line number Diff line number Diff line change
Expand Up @@ -673,8 +673,9 @@ def get_packages(self, invalid_sources=None):
))

for download in downloads:
download.update(download_info)
info['releases'].append(download)
new_download = download_info.copy()
new_download.update(download)
info['releases'].append(new_download)

except (DownloaderException, ClientException, ProviderException) as e:
self.broken_packages[info['name']] = e
Expand Down Expand Up @@ -741,8 +742,9 @@ def get_packages(self, invalid_sources=None):
))

for download in downloads:
download.update(download_info)
info['releases'].append(download)
new_download = download_info.copy()
new_download.update(download)
info['releases'].append(new_download)

except (DownloaderException, ClientException, ProviderException) as e:
self.broken_packages[info['name']] = e
Expand Down

0 comments on commit a8262a9

Please sign in to comment.