New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set json-object-type to alist, as expected by direnv--summarise-changes #72

Merged

wbolster merged 1 commit into wbolster:master from collares:json-alist

Oct 11, 2021

Contributor

collares commented Oct 10, 2021 •

edited

Loading

Using emacs-direnv with lean-mode, I want to run direnv-update-environment before a particular function runs by doing

(advice-add 'lean-setup-rootdir :before #'direnv-update-environment)

but that function is called in a scope where json-object-type is set to 'plist, which breaks direnv--summarise-changes.


          set json-object-type to alist, as expected by direnv--summarise-changes

d3a7ba9

wbolster approved these changes

View reviewed changes

wbolster merged commit c4bbbce into wbolster:master

Owner

wbolster commented Oct 11, 2021

mutable global state 🙄 what can go wrong…

thanks, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet