Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API host default value #7933

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Conversation

GGP1
Copy link
Member

@GGP1 GGP1 commented Oct 24, 2024

Description

Updates the Management API host default value to include IPv6 (['0.0.0.0', '::']).

Checks

Docs building

  • Compiles without warnings.

Code formatting and web optimization

  • Uses three spaces indentation.
  • Adds or updates meta descriptions accordingly.
  • Updates the redirects.js script if necessary (check this guide).

Writing style

  • Uses present tense, active voice, and semi-formal registry.
  • Uses short, simple sentences.
  • Uses bold for user interface elements, italics for key terms or emphasis, and code font for Bash commands, file names, REST paths, and code.

@GGP1 GGP1 self-assigned this Oct 24, 2024
@GGP1 GGP1 linked an issue Oct 24, 2024 that may be closed by this pull request
@GGP1 GGP1 force-pushed the bug/7921-api-host-default-value branch 2 times, most recently from f7845e6 to e29c016 Compare October 24, 2024 18:01
@GGP1 GGP1 force-pushed the bug/7921-api-host-default-value branch from e29c016 to bd7b9ad Compare October 25, 2024 12:45
@GGP1 GGP1 changed the base branch from 4.9 to 4.9.2 October 25, 2024 12:45
nico-stefani
nico-stefani previously approved these changes Oct 25, 2024
Copy link
Member

@nico-stefani nico-stefani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fdalmaup
fdalmaup previously approved these changes Oct 25, 2024
Copy link
Member

@fdalmaup fdalmaup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@javimed javimed added level/task Task issue type/bug Bug issue labels Oct 25, 2024
@javimed javimed dismissed stale reviews from fdalmaup and nico-stefani via 4d22ca7 October 25, 2024 13:56
@javimed javimed merged commit 92b45ef into 4.9.2 Oct 25, 2024
2 checks passed
@javimed javimed deleted the bug/7921-api-host-default-value branch October 25, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level/task Task issue type/bug Bug issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update API configuration sections for IPv6 connections
4 participants