Get agent configuration from API #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertomn86
force-pushed
the
dev-query-config
branch
from
d349d02 to
ac852a5
Compare
jesuslinares
requested review from
mgmacias95
and removed request for
jesuslinares,
santiago-bassett and
vikman90
mgmacias95
suggested changes
Jun 15, 2018
controllers/agents.js
Outdated
| logger.debug(req.connection.remoteAddress + " GET /agents/:agent_id/config/:component/:configuration"); | ||
|
|
||
| var data_request = {'function': '/agents/:agent_id/config/:component/:configuration', 'arguments': {}}; | ||
| var filters = {'agent_id': 'names', 'component': 'names', 'configuration': 'names'}; |
There was a problem hiding this comment.
The agent_id must be filtered as numbers, not as names.
wazuh-api/controllers/agents.js
Line 508 in 03cccb3
albertomn86
force-pushed
the
dev-query-config
branch
from
ac852a5 to
46db7a5
Compare
albertomn86
force-pushed
the
dev-query-config
branch
from
1f663f4 to
322b5d1
Compare
TJOSERAFAEL
force-pushed
the
dev-query-config
branch
from
322b5d1 to
0bf9999
Compare
mgmacias95
approved these changes
Sep 7, 2018
…into dev-query-config
mgmacias95
suggested changes
Sep 21, 2018
There was a problem hiding this comment.
Are there any necessary extra steps to execute these new steps? (Adding extra configuration/agents?). Please, update this https://github.com/wazuh/wazuh-api/blob/master/test/README.md.
models/wazuh-api.py
Outdated
| @@ -196,6 +196,8 @@ def usage(): | |||
| 'PUT/agents/:agent_id/upgrade_custom': Agent.upgrade_agent_custom, | |||
| '/agents/:agent_id/upgrade_result': Agent.get_upgrade_result, | |||
|
|
|||
| # Read remote configuration | |||
| '/agents/:agent_id/config/:component/:configuration': Agent.get_config, | |||
There was a problem hiding this comment.
When merging to 3.7 there will be a conflict with Distributed API. Now API calls are defined here: https://github.com/wazuh/wazuh/blob/3.7/framework/wazuh/cluster/dapi/requests_list.py. This call should be distributed_master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request add the capability to get the agent configuration using the API.
wazuh/wazuh#548