Update for instal_api.sh to create symbolic link to htpasswd properly. #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BraulioV
suggested changes
Oct 16, 2018
install_api.sh
Outdated
| exec_cmd "ln -s $API_PATH/node_modules/htpasswd/bin/htpasswd $API_PATH/configuration/auth/htpasswd" | ||
|
|
||
| # it is necessary to remove htpasswd in order to correctly create the symbolic link | ||
| if [ -e $API_PATH/configuration/auth/htpasswd ]; then |
There was a problem hiding this comment.
if [ -e some_file ]; then... returns true when the file some_file exists. This means that this file can be a regular file or a symbolic link. Reading issue #203, I guess that the API breaks when htpasswd becomes in a regular file instead of a symbolic link to $API_PATH/node_modules/htpasswd/bin/htpasswd.
So the proper check is if [ -f some_file ]; then...
install_api.sh
Outdated
| fi | ||
|
|
||
| exec_cmd "ln -s $API_PATH/node_modules/htpasswd/bin/htpasswd $API_PATH/configuration/auth/htpasswd" |
There was a problem hiding this comment.
In addition, you can avoid the check and the rm lines if you add the -f option to ln. This will overwrite the destination file:
ln -fs $API_PATH/node_modules/htpasswd/bin/htpasswd $API_PATH/configuration/auth/htpasswd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
This PR is for issue #203. I updated
install_api.shscript to create a symbolic link to/var/ossec/api/node_modules/htpasswd/bin/htpasswdproperly.Best regards,
Demetrio.