Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename package xivo to wazo #144

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

rename package xivo to wazo #144

wants to merge 4 commits into from

Conversation

pc-m
Copy link
Member

@pc-m pc-m commented Jul 18, 2024

Don't worry, I'm just having fun

Using the depends on comment on dependencies does not work because the script that finds sibling python packges does not work when renaming the top level packages. xivo is installed and the dependency does not install xivo so it got nothing to override. There might be a work around using the obsoletes option in setup.py but I'm still unsure it the change would be simple enough to warrant a fix to the script or if I should just merge the change to lib-python first with the compatibility module to avoid breaking everything and then merge all other PR with a dependency

Copy link
Contributor

Build failed.
https://zuul.wazo.community/zuul/t/local/buildset/a7dcb78e87864a0abfa68c1c2a6e67ae

tox-linters FAILURE in 6m 26s
wazo-tox-py39 FAILURE in 6m 10s
wazo-tox-integration-py39 FAILURE in 7m 52s
✔️ debian-packaging-bullseye SUCCESS in 1m 48s

@pc-m pc-m force-pushed the rename-top-level-package branch from 2be6fc9 to abac82e Compare July 18, 2024 17:25
Copy link
Contributor

Build succeeded.
https://zuul.wazo.community/zuul/t/local/buildset/c87e3e5c38a54c42a856024831b42abb

✔️ tox-linters SUCCESS in 6m 30s
✔️ wazo-tox-py39 SUCCESS in 6m 14s
✔️ wazo-tox-integration-py39 SUCCESS in 3m 17s
✔️ debian-packaging-bullseye SUCCESS in 1m 49s

Copy link
Contributor

Build succeeded.
https://zuul.wazo.community/zuul/t/local/buildset/e6c945d482184f1eb44087e2e77c4568

✔️ tox-linters SUCCESS in 6m 39s
✔️ wazo-tox-py39 SUCCESS in 6m 20s
✔️ wazo-tox-integration-py39 SUCCESS in 3m 20s
✔️ debian-packaging-bullseye SUCCESS in 1m 49s

the goal is to still provide the xivo package for a while without having
too much code to maintain to keep it working
@pc-m pc-m force-pushed the rename-top-level-package branch from 62dac9f to 2ab68c2 Compare July 18, 2024 18:08
Copy link
Contributor

Build succeeded.
https://zuul.wazo.community/zuul/t/local/buildset/038af9c7c6e545f1b908ece37e9c7e56

✔️ tox-linters SUCCESS in 4m 22s
✔️ wazo-tox-py39 SUCCESS in 4m 13s
✔️ wazo-tox-integration-py39 SUCCESS in 3m 24s
✔️ debian-packaging-bullseye SUCCESS in 1m 53s

use a python alias to deprecate the xivo package instead of a symlink.
this allows the deprecation warning to be displayed
Copy link
Contributor

Build succeeded.
https://zuul.wazo.community/zuul/t/local/buildset/989304349e0d40688a1d8df86230c335

✔️ tox-linters SUCCESS in 6m 22s
✔️ wazo-tox-py39 SUCCESS in 6m 09s
✔️ wazo-tox-integration-py39 SUCCESS in 3m 24s
✔️ debian-packaging-bullseye SUCCESS in 1m 51s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant