Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed type of 'error' property in response #17

Merged
merged 6 commits into from
Nov 4, 2019

Conversation

morganpackard
Copy link
Contributor

The 'error' property of response is actually an Exception, not an array as specified in the comment.

The error property is created and passed here.

@codecov-io
Copy link

codecov-io commented Oct 10, 2019

Codecov Report

Merging #17 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #17   +/-   ##
=======================================
  Coverage       100%   100%           
+ Complexity       60     59    -1     
=======================================
  Files             5      5           
  Lines           143    142    -1     
=======================================
- Hits            143    142    -1
Impacted Files Coverage Δ Complexity Δ
src/Renderer.php 100% <0%> (ø) 34% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8c0d01...de9007b. Read the comment docs.

@morganpackard morganpackard force-pushed the error_property_is_exception branch from 8e8503e to c3a6de0 Compare October 31, 2019 18:38
@roippi roippi merged commit 20ec905 into wayfair:master Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants