Change prepareRequest to a reducer #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
=======================================
Coverage 100% 100%
+ Complexity 61 60 -1
=======================================
Files 5 5
Lines 169 143 -26
=======================================
- Hits 169 143 -26
Continue to review full report at Codecov.
|
ballercat
changed the title
added 3 commits
February 22, 2018 10:55
ballercat
changed the title
|
Hey Ben, could you take a look at this when you get a chance? Should be ready to go. |
roippi
reviewed
Feb 23, 2018
src/Renderer.php
Outdated
| } | ||
| return $job; | ||
| }, $jobs); | ||
| $parsedJobs = $jobs; |
There was a problem hiding this comment.
can I ask why you called this parsedJobs? there's no parsing going on here
There was a problem hiding this comment.
Because I misread prepared will fix!
|
LGTM after nit |
roippi
added a commit
that referenced
this pull request
Feb 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change changes the
prepareRequestto behave as a reducer for jobs instead of a mapper(?).