Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node-sass to latest version to fix build #10

Merged
merged 1 commit into from
May 18, 2020

Conversation

fenech
Copy link

@fenech fenech commented May 18, 2020

With v4.13.0 on a system with process.versions.modules = 83,
npm install fails because it attempts to download:

https://github.com/sass/node-sass/releases/download/v4.13.0/linux_musl-x64-83_binding.node

which doesn't exist.

With v4.13.0 on a system with process.versions.modules = 83,
npm install fails because it attempts to download:

https://github.com/sass/node-sass/releases/download/v4.13.0/linux_musl-x64-83_binding.node

which doesn't exist.

Signed-off-by: Tom Fenech <tomjwfenech@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented May 18, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@offbeatful offbeatful merged commit c3eacfa into wayfair:master May 18, 2020
@offbeatful
Copy link
Collaborator

Thanks for your contribution - it was merged.

@jasonkatz
Copy link

Hi - can the new version with this change get published to npm? https://www.npmjs.com/package/dociql still points at 1.0.3, and I'm running into this error upon installation.

@offbeatful
Copy link
Collaborator

offbeatful commented Oct 1, 2020 via email

@jasonkatz
Copy link

Thanks!

@jasonkatz
Copy link

@offbeatful Any update on when you'll be able to release the new version?

@saeedataion
Copy link

@offbeatful any update to release the latest version on npm?

@offbeatful
Copy link
Collaborator

New version is available.

@saeedataion
Copy link

@offbeatful Thanks for this.
I've noticed some vulnerabilities when running npm audit. Any solution to this?
vulners

@offbeatful
Copy link
Collaborator

Hey, feel free to open a new issue or submit a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants