chore: Restructure repo for libwaysip #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shinyzenith <aakashsensharma@gmail.com>
|
The cargo is the newest construction of rust package, you can see what iced do. So I think it is good. so I don't think change back the cargo.toml to the old structure is good.. |
| @@ -1,47 +1,12 @@ | |||
| [package] | |||
| name = "libwaysip" | |||
There was a problem hiding this comment.
Do not change here, this way can keep the version of waysip and libwaysip in the same version, and both can be published to crate
| @@ -12,4 +12,4 @@ authors.workspace = true | |||
|
|
|||
| [dependencies] | |||
| clap = { version = "4.4.10", features = ["derive"] } | |||
| libwaysip.workspace = true | |||
| libwaysip = { path = "../libwaysip" } | |||
There was a problem hiding this comment.
Do not change back to path way, this will make only waysip can be published to waycrate
| [package] | ||
| name = "libwaysip" | ||
| description = "Library for facilitating wayland native area selection" | ||
| version.workspace = true |
There was a problem hiding this comment.
This keyword means to use the the version top workspace project. Before I set the workspace to libwaysip, but now you set nothing,so here you will get empty
Decodetalkers
requested changes
Dec 7, 2023
|
Ok, I have already change the structure.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.