Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error messages when formatting telemetry #81

Merged
merged 2 commits into from
Apr 6, 2022
Merged

Improve error messages when formatting telemetry #81

merged 2 commits into from
Apr 6, 2022

Conversation

oppegard
Copy link
Contributor

@oppegard oppegard commented Apr 5, 2022

No description provided.

@oppegard oppegard requested a review from keep94 April 5, 2022 11:50
keep94
keep94 approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@keep94 keep94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this work Glenn. I am approving as is, but I did have some questions / comments so read on.

senders/formatter.go Outdated Show resolved Hide resolved
senders/formatter.go Outdated Show resolved Hide resolved
senders/formatter_test.go Show resolved Hide resolved
@oppegard oppegard merged commit 6be54bd into master Apr 6, 2022
@oppegard oppegard deleted the MONIT-27725-improve-errors branch April 6, 2022 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keep94 keep94 keep94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oppegard @keep94