Allow for tagging internal SDK metrics #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update newProxySender to take an additional setter with Otel tag set by the Otel-Collector.
oppegard
reviewed
Feb 4, 2022
oppegard
changed the title
Update proxy.go & client.go to tag internal SDK metrics.
Add a delay in proxy_test.go to make sure connections are made before tests run.
Make the proxy variable local to tests in proxy_test.go.
keep94
requested changes
Feb 5, 2022
keep94
approved these changes
Feb 5, 2022
1. Make a defensive copy of tags, so that the Option SDKMetricsTags() won't change the exisitng tags if the multiple maps for the SDKMetricsTags are provided. 2. Add a TODO to see if there is a better way to avoid the race condition.
Remove sleep from proxy_test.go as we are not able to reproduce the race-condition locally.
Add a channel to avoid the racing condition.
Make proxy_test more reliable
1. Add an option to provide custom reportTicker 2. Add an unit test toverify SDKMetricsTags
oppegard
reviewed
Feb 9, 2022
oppegard
suggested changes
Feb 9, 2022
Reset the map to avoid race condition.
Reset the map to avoid race condition.
Reset the map to avoid race condition.
Reset the map to avoid race condition.
In client_test.go add assertions for the sent requests.
Remove an option to set custom value for reportTicker, as it is causing the race condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update newProxySender to take an additional setter with Otel tag set by
the Otel-Collector.