Add a no-op WavefrontSender implementation #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oppegard
suggested changes
Jun 22, 2021
There was a problem hiding this comment.
Thanks for the submission @mssrinivas! Could you give an example of your use-case that requires a no-op Sender, rather than just not instantiating a Sender at all?
|
@oppegard We have a service A currently using DirectConfig to send metrics to WF. We also have another service B which implements interfaces of service A but do not want to enable metrics capturing. Since things are tightly coupled we wanted to have a way to initialize Noop sender. |
oppegard
approved these changes
Jun 23, 2021
oppegard
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.