Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Suite fails if port 8080 is bound #102

Closed
keep94 opened this issue Sep 1, 2022 · 3 comments
Closed

Test Suite fails if port 8080 is bound #102

keep94 opened this issue Sep 1, 2022 · 3 comments

Comments

@keep94
Copy link
Contributor

keep94 commented Sep 1, 2022

If port 8080 is bound by an ordinary web app, the test suite of this module fails.

Expected behavior: The test suite should pass even if port 8080 is bound.

@oppegard
Copy link
Contributor

@keep94 was this not fixed in #105, and this issue should be closed?

@oppegard
Copy link
Contributor

@keep94 FYI, Github can automatically close issues by linking a PR to it through a commit message. For example, if the commit message includes text that says:

Fixes #102

For more info on the syntax Github will handle, check out https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

@keep94
Copy link
Contributor Author

keep94 commented Sep 14, 2022

fixed in #105

@keep94 keep94 closed this as completed Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants