wip: enable a bunch of new linting rules at once #280
LukeWinikatesAnnotations
14 errors and 10 warnings
|
Go 1.19.x:
internal/auth/csp/api_token_client.go#L34
Error return value of `resp.Body.Close` is not checked (errcheck)
|
|
Go 1.19.x:
internal/auth/csp/client_credentials.go#L43
Error return value of `resp.Body.Close` is not checked (errcheck)
|
|
Go 1.19.x:
internal/reporter.go#L115
Error return value of `resp.Body.Close` is not checked (errcheck)
|
|
Go 1.19.x:
senders/test_server_test.go#L74
Error return value of `request.Body.Close` is not checked (errcheck)
|
|
Go 1.19.x:
senders/test_server_test.go#L80
Error return value of `r.Close` is not checked (errcheck)
|
|
Go 1.19.x:
senders/noop_test.go#L56
Error return value of `wf.Flush` is not checked (errcheck)
|
|
Go 1.19.x:
internal/sanitize_test.go#L17
string `heartbeat` has 5 occurrences, make it a constant (goconst)
|
|
Go 1.19.x:
internal/span/formatter_test.go#L30
string `"order.shirts" source="test_source" traceId=7b3bf470-9456-11e8-9eb6-529269fb1459` has 3 occurrences, make it a constant (goconst)
|
|
Go 1.19.x:
internal/sdkmetrics/registry_test.go#L21
assignOp: replace `f.count = f.count + 1` with `f.count++` (gocritic)
|
|
Go 1.19.x:
internal/sdkmetrics/registry_test.go#L23
assignOp: replace `f.errors = f.errors + 1` with `f.errors++` (gocritic)
|
|
Go 1.20.x
The job was canceled because "_1_19_x" failed.
|
|
Go 1.20.x
The operation was canceled.
|
|
Go 1.21.x
The job was canceled because "_1_19_x" failed.
|
|
Go 1.21.x
The operation was canceled.
|
|
Go 1.19.x:
event/events.go#L1
package-comments: should have a package comment (revive)
|
|
Go 1.19.x:
version/version.go#L12
exported: exported var Version should have comment or be unexported (revive)
|
|
Go 1.19.x:
version/version.go#L1
package-comments: should have a package comment (revive)
|
|
Go 1.19.x:
internal/sdkmetrics/noop_registry.go#L3
exported: exported function NewNoOpRegistry should have comment or be unexported (revive)
|
|
Go 1.19.x:
internal/sdkmetrics/metrics.go#L1
package-comments: should have a package comment (revive)
|
|
Go 1.19.x:
internal/sdkmetrics/options.go#L3
exported: exported type RegistryOption should have comment or be unexported (revive)
|
|
Go 1.19.x:
internal/sdkmetrics/real_registry.go#L58
exported: exported function NewMetricRegistry should have comment or be unexported (revive)
|
|
Go 1.19.x:
internal/sdkmetrics/options.go#L5
exported: exported function SetSource should have comment or be unexported (revive)
|
|
Go 1.19.x:
internal/sdkmetrics/registry.go#L13
exported: exported type Incrementer should have comment or be unexported (revive)
|
|
Go 1.19.x:
internal/sdkmetrics/success_tracker.go#L3
exported: exported type SuccessTracker should have comment or be unexported (revive)
|