Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/allow token from secret #301

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feature/allow token from secret #301

wants to merge 2 commits into from

Conversation

dcristobalhMad
Copy link
Contributor

Description

This PR allow to pull the wavefront token from a secret created by your own. Features:

  • Implements conditional check in the deployment to pull the key in an external secret or the secret created in the chart.
  • Implements a logic to create or not the secret depending on the wavefront token and tokenFromSecret values.

Features

  • Allows to use the Gitops paradigm leaving the git secret encrypted for later use by the application.

@dcristobalhMad
Copy link
Contributor Author

Hi 👋 !
Is it required something else to merge this change?
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dcristobalhMad