Fix gaps and cracks issues #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daleeidd
approved these changes
Jan 7, 2021
| @@ -809,6 +809,18 @@ void LateUpdatePosition() | |||
| // maintain y coordinate - sea level | |||
| pos.y = Root.position.y; | |||
|
|
|||
| // Don't land very close to regular positions where things are likely to snap to, because different tiles might | |||
| // land on either side of a snap boundary due to numerical error and snap to the wrong positions. Nudge away from | |||
| // common by using increments of 1/60 which have lots of factors. | |||
There was a problem hiding this comment.
Should we add :OceanGridPrecisionErrors to keep track?
|
Great news, thanks! I updated the descr above about what we might try if we get reports of gaps or cracks in the future. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status: Ready to merge
Fix for two issues, both tracked by #665
Gaps: When ocean placed near a regular position (such as an integral boundary or multiple of 0.333333, etc), precision issues related either to how transforms propagate in the unity hierarchy or how the values arrive to the shader mean different tiles can snap to different locations and leave a gap. This adds a slight nudge to push the ocean away from a bunch of common boundaries). The nudge is very small and will not affect the ocean simulation/rendering as everything snaps to much larger values than the nudge. In the future, if gaps appear, it may be the boundary is not on 1/60. The boundary might be lod resolution / lod 0 width. If we get a report of gaps, we should get the camera transform and oceanrenderer settings, and see if we can compute the boundary.
Thin cracks: The scale of each tile is increased by a small epsilon. This should be subpixel, but should be large enough to overcome precision issues. If cracks appear in the future, this value could be increased. It might be that this value is too small when far from the origin, we could potentially scale the epsilon by dist from origin to help combat this if needed.
@daleeidd could you let me know what you think and please give this a run on mac if you could. Thanks!