Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move moments API from beta to public #111

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brunnjf
Copy link
Contributor

@brunnjf brunnjf commented Aug 13, 2018

1 of 2 steps to move moments API to public. This should wait until the internal changes to GraphQL have been made to make this public.

@UOKS FYI and for review

@brunnjf
Copy link
Contributor Author

brunnjf commented Aug 13, 2018

@miguelestrada @jarusso ready for review, pending the changes to actually move moments to public internally.

Copy link
Member

@miguelestrada miguelestrada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will await indication that it is ok to merge.

@jarusso
Copy link
Collaborator

jarusso commented Aug 14, 2018

looks good but we need to add an entry to What's New as well for this

@brunnjf
Copy link
Contributor Author

brunnjf commented Aug 14, 2018

Good catch. I will do that @jarusso

The What's New entry includes a date, so I have it ready but have to wait until we are just about set to commit it.

@miguelestrada
Copy link
Member

@brunnjf bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants