Fix SDK tests to build & run properly on Linux #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mediumTaj
approved these changes
May 18, 2018
| // allow zip files to propagate through object storage, so that | ||
| // they will be deleted when the service deletes the classifier | ||
| // (otherwise they remain and dramatically slow down the tests) | ||
| sleep(15) // wait 15 seconds |
There was a problem hiding this comment.
Are we waiting for the classifier to be ready or failed (a short time after, hah)? I think you might be right when you said we should move away from deleting in the tests and do a purge every week or so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces some test logic that uses features/capabilities that are not available on Linux.
Specifically:
addTeardownBlock, which is not available on Linux. The new logic reuses existing resources in subsequent test runs, so leaving "dangling" resources after test completion is not an issue.wait(for:withwaitForExpectationsbecause the former is not supported on Linux. This required some rework to prevent overlap in the scopes of expectations.I also updated the Dockerfile to use the new Swift 4.1 docker image.
With these changes, the SDK again builds and runs on Linux. The results of my last full test run were:
Two of these failures were VR tests that were disabled in Xcode, so I also disabled them in Linux, two were timeouts in VR tests, and one was just an intermittent failure.